On Tue, Dec 20, 2022 at 10:29:06AM -0800, Dmitry Torokhov wrote: > On Tue, Dec 20, 2022 at 03:58:11PM +0200, Andy Shevchenko wrote: > > On Mon, Dec 19, 2022 at 11:20:15AM -0800, Dmitry Torokhov wrote: > > > There are no more users of these APIs in the mainline kernel, remove > > > them. This leaves of_get_named_gpio() as the only legacy OF-specific > > > API. ... > > > - desc = of_get_named_gpiod_flags(np, list_name, index, flags); > > > + desc = of_get_named_gpiod_flags(np, propname, index, NULL); > > > > I didn't get it. The commit message and the subject says there are no more > > users of these APIs, why is it still here? How is it compiled? > > gpio vs gpiod strikes again ;) We are removing > of_get_named_gpio_flags(), but of_get_named_gpiod_flags() is a local > helper in gpiolib-of.c and is still very much in use there and I have no > plans removing it. Right, thank you for clarification. Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko