Hi Andy, On Mon, Dec 19, 2022 at 02:26:27PM +0200, Andy Shevchenko wrote: > Now it becomes visible that we can deduplicate SoC specific > *_COMMUNITY() macros across the Intel pin control drivers. > For that, introduce a common INTEL_COMMUNITY_GPPS() and > INTEL_COMMUNITY_SIZE() macros in the pinctrl-intel.h. You should really start learning how to use --cover-letter option with git format-patch because for anything more than one patch pretty much requires such. Here I would really like to see how much lines this series ends up removing :) The series looks good to me, though.