Re: [libgpiod][PATCH] tools: tests: remove leftover echo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 12, 2022 at 10:35:10AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> This looks like some unneeded leftover from the development that was
> missed because bats intercepts all echo output.
> 

Indeed - you only see it when a test fails, and I obviously missed
removing it after getting the offending test to pass.

Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>

> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
>  tools/gpio-tools-test.bats | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bats
> index bf7f3d6..adbce94 100755
> --- a/tools/gpio-tools-test.bats
> +++ b/tools/gpio-tools-test.bats
> @@ -392,7 +392,6 @@ request_release_line() {
>  
>  	run_tool gpioinfo
>  
> -    echo "$output"
>  	output_contains_line "${GPIOSIM_CHIP_NAME[sim0]} - 4 lines:"
>  	output_contains_line "${GPIOSIM_CHIP_NAME[sim1]} - 8 lines:"
>  	output_regex_match "\\s+line\\s+0:\\s+unnamed\\s+input"
> -- 
> 2.37.2
> 



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux