Re: [PATCH v3] pinctrl: thunderbay: fix possible memory leak in thunderbay_build_functions()

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Nov 29, 2022 at 1:01 PM Gaosheng Cui <cuigaosheng1@xxxxxxxxxx> wrote:

> The thunderbay_add_functions() will free memory of thunderbay_funcs
> when everything is ok, but thunderbay_funcs will not be freed when
> thunderbay_add_functions() fails, then there will be a memory leak,
> so we need to add kfree() when thunderbay_add_functions() fails to
> fix it.
>
> In addition, doing some cleaner works, moving kfree(funcs) from
> thunderbay_add_functions() to thunderbay_build_functions().
>
> Fixes: 12422af8194d ("pinctrl: Add Intel Thunder Bay pinctrl driver")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@xxxxxxxxxx>
> ---
> v3:
> - Doing some cleaner works, moving kfree(funcs) from thunderbay_add_functions()
>   to thunderbay_build_functions(), and update the commit message, thanks!

Patch applied as non-urgent fix.

Yours,
Linus Walleij