Re: [PATCH v10 1/2] gpio: loongson: add gpio driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 03, 2022 at 05:27:31PM +0200, Andy Shevchenko wrote:
> On Sat, Dec 03, 2022 at 06:53:20PM +0800, Yinbo Zhu wrote:
> > 在 2022/12/3 18:03, Linus Walleij 写道:
> > > On Thu, Dec 1, 2022 at 1:33 PM Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> wrote:
> > > > +config GPIO_LOONGSON_64BIT
> > > > +       tristate "Loongson 64 bit GPIO support"
> > > > +       depends on LOONGARCH || COMPILE_TEST
> > > > +       select GPIO_GENERIC
> > > > +       select GPIOLIB_IRQCHIP
> > > If the kernelbots start complaining you might need to add a:
> > > 
> > > select IRQ_DOMAIN_HIERARCHY
> > > 
> > > here.
> > 
> > Bartosz had merged my patch and I will add a change on top of the existing
> > series.
> 
> I don;'t know why he had done that, the driver requires a lot of cleanups,
> e.g. why it uses acpi.h, what that "nice" container of the platform device for.

+ we have macros for get_direction() returned values and so on.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux