Re: [PATCH 2/5] gpio: tps68470: Make tps68470_gpio_output() always set the initial value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans

On 28/11/2022 21:44, Hans de Goede wrote:
Make tps68470_gpio_output() call tps68470_gpio_set() for output-only pins
too, so that the initial value passed to gpiod_direction_output() is
honored for these pins too.

Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>


Reviewed-by: Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx>

Tested-by: Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx>

---
  drivers/gpio/gpio-tps68470.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-tps68470.c b/drivers/gpio/gpio-tps68470.c
index 778a72cf800c..2ca86fbe1d84 100644
--- a/drivers/gpio/gpio-tps68470.c
+++ b/drivers/gpio/gpio-tps68470.c
@@ -91,13 +91,13 @@ static int tps68470_gpio_output(struct gpio_chip *gc, unsigned int offset,
  	struct tps68470_gpio_data *tps68470_gpio = gpiochip_get_data(gc);
  	struct regmap *regmap = tps68470_gpio->tps68470_regmap;
+ /* Set the initial value */
+	tps68470_gpio_set(gc, offset, value);
+
  	/* rest are always outputs */
  	if (offset >= TPS68470_N_REGULAR_GPIO)
  		return 0;
- /* Set the initial value */
-	tps68470_gpio_set(gc, offset, value);
-
  	return regmap_update_bits(regmap, TPS68470_GPIO_CTL_REG_A(offset),
  				 TPS68470_GPIO_MODE_MASK,
  				 TPS68470_GPIO_MODE_OUT_CMOS);



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux