Re: [brgl:gpio/for-next 56/58] drivers/gpio/gpio-max732x.c:613:42: warning: initialization of 'const struct i2c_device_id *' from 'int' makes pointer from integer without a cast

[Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>]

On Wed, 23 Nov 2022 at 17:09, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> On Wed, Nov 23, 2022 at 4:49 PM kernel test robot <lkp@xxxxxxxxx> wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
> > head:   3687a82b1db1c827cc4b367e3efde3235f68d9f6
> > commit: 95889cd3c8d8c64b3cd0baaecdaca2d82312b5fc [56/58] gpio: max732x: Convert to i2c's .probe_new()
> > config: m68k-allyesconfig
> > compiler: m68k-linux-gcc (GCC) 12.1.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git/commit/?id=95889cd3c8d8c64b3cd0baaecdaca2d82312b5fc
> >         git remote add brgl https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git
> >         git fetch --no-tags brgl gpio/for-next
> >         git checkout 95889cd3c8d8c64b3cd0baaecdaca2d82312b5fc
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/gpio/
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >
> > All warnings (new ones prefixed by >>):
> >
> >    drivers/gpio/gpio-max732x.c: In function 'max732x_probe':
> >    drivers/gpio/gpio-max732x.c:613:42: error: implicit declaration of function 'i2c_client_get_device_id'; did you mean 'i2c_get_device_id'? [-Werror=implicit-function-declaration]
> >      613 |         const struct i2c_device_id *id = i2c_client_get_device_id(client);
> >          |                                          ^~~~~~~~~~~~~~~~~~~~~~~~
> >          |                                          i2c_get_device_id
> > >> drivers/gpio/gpio-max732x.c:613:42: warning: initialization of 'const struct i2c_device_id *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> >    cc1: some warnings being treated as errors
> >
> >
> > vim +613 drivers/gpio/gpio-max732x.c
> >
> >    610
> >    611  static int max732x_probe(struct i2c_client *client)
> >    612  {
> >  > 613          const struct i2c_device_id *id = i2c_client_get_device_id(client);
>
> Depends on commit 662233731d66cf41 ("i2c: core: Introduce
> i2c_client_get_device_id helper function") in i2c/i2c/for-next?
>

Yes, already backed those out. Thanks.

Bart