Re: [PATCH] pinctrl: call of_node_put() when breaking out of for_each_available_child_of_node()

[Damien Le Moal <Damien.LeMoal@xxxxxxx>]

On 2022/11/22 16:33, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@xxxxxxxxxx>
> 
> Since for_each_available_child_of_node() will increase the refcount of
> node, we need to call of_node_put() manually when breaking out of the
> iteration.
> 
> Fixes: d4c34d09ab03 ("pinctrl: Add RISC-V Canaan Kendryte K210 FPIOA driver")
> Signed-off-by: ZhangPeng <zhangpeng362@xxxxxxxxxx>
> ---
>  drivers/pinctrl/pinctrl-k210.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index ecab6bf63dc6..ad4db99094a7 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -862,8 +862,10 @@ static int k210_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
>  	for_each_available_child_of_node(np_config, np) {
>  		ret = k210_pinctrl_dt_subnode_to_map(pctldev, np, map,
>  						     &reserved_maps, num_maps);
> -		if (ret < 0)
> +		if (ret < 0) {
> +			of_node_put(np);
>  			goto err;
> +		}
>  	}
>  	return 0;
>  

Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>

-- 
Damien Le Moal
Western Digital Research