Re: [PATCH resend] pinctrl: starfive: Use existing variable gpio

[Emil Renner Berthing <kernel@xxxxxxxx>]

On Mon, 21 Nov 2022 at 16:51, Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
>
> Use the existing variable "gpio", instead of obtaining the hwirq number
> again.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Thanks!
Reviewed-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx>

> ---
>  drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c
> index bdf61cfd143a5120..6fe5e1e9baa9b20a 100644
> --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c
> +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c
> @@ -1086,7 +1086,7 @@ static void starfive_irq_mask(struct irq_data *d)
>         writel_relaxed(value, ie);
>         raw_spin_unlock_irqrestore(&sfp->lock, flags);
>
> -       gpiochip_disable_irq(&sfp->gc, d->hwirq);
> +       gpiochip_disable_irq(&sfp->gc, gpio);
>  }
>
>  static void starfive_irq_mask_ack(struct irq_data *d)
> @@ -1115,7 +1115,7 @@ static void starfive_irq_unmask(struct irq_data *d)
>         unsigned long flags;
>         u32 value;
>
> -       gpiochip_enable_irq(&sfp->gc, d->hwirq);
> +       gpiochip_enable_irq(&sfp->gc, gpio);
>
>         raw_spin_lock_irqsave(&sfp->lock, flags);
>         value = readl_relaxed(ie) | mask;
> --
> 2.25.1
>