Re: [PATCH] pinconf-generic: fix style issues in pin_config_param doc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 17, 2022 at 12:35:42PM +0000, Niyas Sait wrote:
> Fixes following issues introduced in a  previous commit
> to clarify values for pin config pull up and down types.
> 
> - replace spaces with tabs to be consistent with rest of the doc
> - use capitalization for unit (ohms -> Ohms)

Thank you!

Either folded or separated
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Signed-off-by: Niyas Sait <niyas.sait@xxxxxxxxxx>
> ---
>  include/linux/pinctrl/pinconf-generic.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/pinctrl/pinconf-generic.h b/include/linux/pinctrl/pinconf-generic.h
> index 11e7394bcc70..537064a997a5 100644
> --- a/include/linux/pinctrl/pinconf-generic.h
> +++ b/include/linux/pinctrl/pinconf-generic.h
> @@ -36,7 +36,7 @@ struct pinctrl_map;
>   * @PIN_CONFIG_BIAS_PULL_DOWN: the pin will be pulled down (usually with high
>   *	impedance to GROUND). If the argument is != 0 pull-down is enabled,
>   *	the value is interpreted by the driver and can be custom or an SI unit
> - *  such as ohms.
> + *  	such as Ohms.
>   * @PIN_CONFIG_BIAS_PULL_PIN_DEFAULT: the pin will be pulled up or down based
>   *	on embedded knowledge of the controller hardware, like current mux
>   *	function. The pull direction and possibly strength too will normally
> @@ -48,7 +48,7 @@ struct pinctrl_map;
>   * @PIN_CONFIG_BIAS_PULL_UP: the pin will be pulled up (usually with high
>   *	impedance to VDD). If the argument is != 0 pull-up is enabled,
>   *	the value is interpreted by the driver and can be custom or an SI unit
> - *  such as ohms.
> + *	such as Ohms.
>   * @PIN_CONFIG_DRIVE_OPEN_DRAIN: the pin will be driven with open drain (open
>   *	collector) which means it is usually wired with other output ports
>   *	which are then pulled up with an external resistor. Setting this
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux