Re: [libgpiod][PATCH V9 0/8] libgpiod: Add Rust bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Thu, Nov 17, 2022 at 10:56 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> Do these problems you faced apply to libgpiod too? Honestly, putting
> automatically generated files in the repo just feels wrong. It defeats
> the whole purpose of code generation. If we can't reliably regenerate
> them, then it sounds like a problem with the tools, not the library.
> Maybe we don't need to worry about that just yet?

If the library is stable enough, then removing a heavy build
dependency on bindgen may be worth it. But yeah, by default I would
avoid it unless one is sure it is possible.

Though, if one can store it because it is fixed, at that point one may
take advantage of that and manually write (or tweak) the bindings
instead.

In any case, I would explain the rationale one way or the other in the
commit message or ideally in the `README.MD`.

One thing I may have missed: why is there a `-sys` crate for one of
the bindings but not the other? It may be a good idea to document the
intention as well.

Cheers,
Miguel



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux