Re: [libgpiod][PATCH V9 0/8] libgpiod: Add Rust bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 17, 2022 at 11:40 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 17-11-22, 11:18, Bartosz Golaszewski wrote:
> > Do these problems you faced apply to libgpiod too?
>
> I faced them with libgpiod only :(
>
> > Honestly, putting
> > automatically generated files in the repo just feels wrong.
>
> I agree, but ...
>
> > It defeats
> > the whole purpose of code generation. If we can't reliably regenerate
> > them, then it sounds like a problem with the tools, not the library.
> > Maybe we don't need to worry about that just yet?
>
> it isn't about reliability of the generated code, but making everyone do it,
> even if they don't need to.
>
> Also, the code generated here is Rust code wrappers and other declarations,
> which let us call the C helpers eventually. It can be considered like hand
> written code here, for the argument that it is automatically generated stuff.
> Just that we have a tool (bindgen) here which lets us generate it automatically,
> without introducing bugs.
>
> Anyway, I am fine with whatever you decide.
>

Let me propose a different solution. When preparing release tarballs
with autotools, certain files are generated automatically that go into
the tarball but are never part of the repository. This way developers
don't have to deal with the automatically generated files polluting
the repo while end-users get a tarball with less dependencies and
reproducible results.

It's called the dist-local hook in automake.

Does it sound like something we could use here?

Bart



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux