On Wed, Nov 16, 2022 at 04:17:28PM +0200, Andy Shevchenko wrote: > Some of the functions are using struct fwnode_handle, some struct device > pointer. In the GPIO library the firmware node of the GPIO device is the > same as GPIO node of the GPIO chip. Due to this fact we may use former > to access properties everywhere in the code. Citing myself from another thread to the topic: Nevertheless, for of_gpiochip_add()/of_gpiochip_remove() and of_mm_gpiochip_add_data() I still left use of fwnode, because it feels the right thing to do: we are taking reference on the input data in such cases. -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 1/1] gpiolib: Unify access to the device properties
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 1/1] gpiolib: Unify access to the device properties
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Wed, 16 Nov 2022 16:41:28 +0200
- In-reply-to: <20221116141728.72491-1-andriy.shevchenko@linux.intel.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20221116141728.72491-1-andriy.shevchenko@linux.intel.com>
- References:
- [PATCH v1 1/1] gpiolib: Unify access to the device properties
- From: Andy Shevchenko
- [PATCH v1 1/1] gpiolib: Unify access to the device properties
- Prev by Date: Re: [rft, PATCH v3 1/1] gpiolib: Get rid of not used of_node member
- Next by Date: [GIT PULL] pin control fixes for v6.1
- Previous by thread: [PATCH v1 1/1] gpiolib: Unify access to the device properties
- Next by thread: Re: [PATCH v1 1/1] gpiolib: Unify access to the device properties
- Index(es):
 |