Re: [PATCH v2 1/2] gpio: loongson: add dts/acpi gpio support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2022/11/15 下午6:20, Thomas Bogendoerfer 写道:
On Tue, Nov 15, 2022 at 05:53:26PM +0800, Yinbo Zhu wrote:
+/* ============== Data structrues =============== */
+
+/* gpio data */
+struct platform_gpio_data {
+       u32 gpio_conf;
+       u32 gpio_out;
+       u32 gpio_in;
+       u32 support_irq;
+       char *label;
+       int gpio_base;
+       int ngpio;
+};

No idea why you would need to duplicate it like this either. And why
put it in arch/.
because loongson platform include mips and loongarch, and the gpio device
data was defined in arch/ in leagcy loongson gpio driver.  so the
latest loongson gpio drvier add platform_gpio_data in same dir.

put the struct into a new file in  include/linux/platform_data and
use that.

Thomas.
Hi Thomas,

I think it is okay for me about your advice. I will move gpio platform
data in include/linux/platform_data.

Thanks
Yinbo.






[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux