Re: [libgpiod v2][PATCH v4 3/5] tools: tests for line name focussed rework

[Kent Gibson <warthog618@xxxxxxxxx>]

On Tue, Nov 15, 2022 at 02:08:40PM +0100, Bartosz Golaszewski wrote:
> On Mon, Nov 14, 2022 at 5:01 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> >
> > Rework the tools tests and expand to cover new functionality.
> >
> > Signed-off-by: Kent Gibson <warthog618@xxxxxxxxx>
> > ---
> >  tools/gpio-tools-test      |    3 -
> >  tools/gpio-tools-test.bats | 2369 ++++++++++++++++++++++++++++++++++--
> >  2 files changed, 2284 insertions(+), 88 deletions(-)
> >
> > diff --git a/tools/gpio-tools-test b/tools/gpio-tools-test
> > index 234f9bd..1a012dc 100755
> > --- a/tools/gpio-tools-test
> > +++ b/tools/gpio-tools-test
> > @@ -37,9 +37,6 @@ check_prog() {
> >  # Check all required non-coreutils tools
> >  check_prog bats
> >  check_prog modprobe
> > -check_prog rmmod
> > -check_prog udevadm
> > -check_prog timeout
> 
> We do use timeout in the test-suite even after your changes so I'll
> keep this line.
> 

So we do - for the scripts to call themselves - missed that.  Fair enough.

Cheers,
Kent.