Re: [PATCH v2] mips: alchemy: gpio: Include the right header

[Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>]

On Thu, Nov 03, 2022 at 11:15:35AM +0100, Linus Walleij wrote:
> The local GPIO driver in the MIPS Alchemy is including the legacy
> <linux/gpio.h> header but what it wants is to implement a GPIO
> driver so include <linux/gpio/driver.h> instead.
> 
> Cc: Bartosz Golaszewski <brgl@xxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> ChangeLog v1->v2:
> - Collect Philippe's review tag
> - Resend to the right MIPS maintainer
> ---
>  arch/mips/alchemy/common/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/alchemy/common/gpiolib.c b/arch/mips/alchemy/common/gpiolib.c
> index a17d7a8909c4..1b16daaa86ae 100644
> --- a/arch/mips/alchemy/common/gpiolib.c
> +++ b/arch/mips/alchemy/common/gpiolib.c
> @@ -31,7 +31,7 @@
>  #include <linux/init.h>
>  #include <linux/kernel.h>
>  #include <linux/types.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>  #include <asm/mach-au1x00/gpio-au1000.h>
>  #include <asm/mach-au1x00/gpio-au1300.h>
>  
> -- 
> 2.34.1

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]