On Thu, Nov 10, 2022 at 10:14:45PM +0200, Andy Shevchenko wrote: > On Thu, Nov 10, 2022 at 07:12:55PM +0000, Niyas Sait wrote: > > This is a proposal for adding ACPI support to pin controller. > > > > The patch supports following resources introduced in ACPI from v6.2 > > > > - PinFunction > > - PinConfig > > - PinGroupFunction > > - PinGroupConfig > > - PinGroup > > > > The patch has been tested on NXP I.MX8MP Plus platform with ACPI. > > Thank you very much for this work! > > I will take time to review it, presumably next week. > > I'm not sure it will go to the v6/2-rc1 due to tough time range > (we are almost at -rc5), I hope you are not in such hurry. Meanwhile, can we see the DSDT excerpt(s) that shows how you use these resources there? Also note, we need some clarification to be done in the ACPI specification regarding the numbering schema, used in those resources. TL;DR: for Gpio*() the number space is GPIO, for Pin*() is pin control (real pin numbering, since not all of them can be GPIOs and GPIO can have its own additional layer of numbering mapping). -- With Best Regards, Andy Shevchenko