Re: [PATCH v3 7/7] arm64: dts: ti: k3-j721s2-common-proc-board: Add TPS6594x PMIC node

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 09/11/2022 07:55, Matt Ranostay wrote:
> Add TPS6594x PMIC, GPIO, and RTC definitions for j721s2 common processor
> board device tree.
> 
> Signed-off-by: Matt Ranostay <mranostay@xxxxxx>
> ---
>  .../boot/dts/ti/k3-j721s2-common-proc-board.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> index a7aa6cf08acd..918c0c8d02cf 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> @@ -309,3 +309,20 @@ &mcu_mcan1 {
>  	pinctrl-0 = <&mcu_mcan1_pins_default>;
>  	phys = <&transceiver2>;
>  };
> +
> +&wkup_i2c0 {
> +	status = "okay";
> +	tps6594x: tps6594x@48 {
> +		compatible = "ti,tps6594x";

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof