Re: [PATCH v3 1/7] Documentation: tps6594x: Add DT bindings for the TPS6594x PMIC

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 09/11/2022 07:55, Matt Ranostay wrote:

Missing commit msg.

Use subject prefixes matching the subsystem (git log --oneline -- ...).

> Signed-off-by: Matt Ranostay <mranostay@xxxxxx>
> ---
>  .../devicetree/bindings/mfd/ti,tps6594x.yaml  | 67 +++++++++++++++++++
>  1 file changed, 67 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml b/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml
> new file mode 100644
> index 000000000000..be87f0037bf9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,tps6594x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TPS6594x Power Management Integrated Circuit (PMIC)
> +
> +maintainers:
> +  - Keerthy <j-keerthy@xxxxxx>
> +
> +properties:
> +  compatible:
> +    contains:

Drop contains.

> +      enum:
> +        - ti,tps6594x

No wildcards in compatibles.

> +
> +  reg:
> +    const: 0x48
> +    description: I2C slave address

Drop description.

> +
> +  ti,system-power-controller:
> +    type: boolean
> +    description: PMIC is controlling the system power.
> +
> +  rtc:
> +    type: object
> +    $ref: /schemas/rtc/rtc.yaml#
> +    unevaluatedProperties: false
> +    properties:
> +      compatible:
> +        const: ti,tps6594x-rtc

No wildcards in compatibles.

> +
> +  gpio:
> +    type: object
> +    unevaluatedProperties: false
> +    properties:
> +      compatible:
> +        const: ti,tps6594x-gpio

No wildcards in compatibles.

> +
> +additionalProperties: false
> +
> +required:
> +  - compatible

> +...

Best regards,
Krzysztof