Re: [PATCH V7 3/8] libgpiod: Add rust wrapper crate

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Wed, Nov 2, 2022 at 2:08 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> On Wed, Nov 02, 2022 at 01:47:44PM +0100, Bartosz Golaszewski wrote:
> > On Wed, Nov 2, 2022 at 5:00 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > >
> > > On 31-10-22, 20:33, Kent Gibson wrote:
> > > > Wrt the Rust bindings, I was assuming that either Viresh would provide
> > > > support, or as his work appears to be on behalf of Linaro that they
> > > > would have an interest in maintaining it.
> > >
> > > I will surely help in maintaining the Rust part. Not an issue.
> > >
> >
> > Sounds like a plan. I'm going through Kent's gpio-tools patches and
> > rust bindings are next in line.
> >
>
> The rust bindings might make it in before they do - you may find that
> they are a bit more different from the old tools than you were expecting.
>

Yeah, I can tell that. :)

I have lots of non-functional minor things to point out - mostly
coding style etc. - that I will probably just fix locally when
applying.

One thing that stands out though is the dependency on libedit - do you
think we could make the gpioset interactive mode a configurable
feature with its own configure switch that could be left out if we
don't want to depend on any external libraries?

Bart

> For my part I'm just wrapping up a quick pass over rust v8, before
> looking for where the python landed.
>
> Cheers,
> Kent.
>