Re: [PATCH v2 1/2] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 28/10/2022 11:05, Russell King (Oracle) wrote:
> On Fri, Oct 28, 2022 at 02:32:02PM +0100, Russell King (Oracle) wrote:
>> Add the DT binding for the Apple Mac System Management Controller GPIOs.
>>
>> Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
>> ---
>>  .../devicetree/bindings/gpio/gpio-macsmc.yaml | 41 +++++++++++++++++++
> 
> Sorry, just realised I hadn't renamed this file. I'll do that for v3.
> Please review assuming I've made that change.

v3 is needed anyway for the tooling/automated checks.

> 
>>  1 file changed, 41 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml
>> new file mode 100644
>> index 000000000000..2bb8faa2c08c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml
>> @@ -0,0 +1,41 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Apple Mac System Management Controller GPIO
>> +
>> +maintainers:
>> +  - Hector Martin <marcan@xxxxxxxxx>
>> +
>> +description:
>> +  This describes the binding for the Apple Mac System Management Controller

Missing change. Drop "This describes the binding for". This is a
description of hardware.

Rest looks good.

>> +  GPIO block.
Best regards,
Krzysztof