Re: [PATCH v2 4/6] gpio: pca953x: Generalize interrupt mask register handling

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Oct 26, 2022 at 01:23:58PM +0200, Levente Révész wrote:

...

> Question:
> 
>     This patch uses the PCA_HAS_INT_MASK bit to encode if the chip has
> 	interrupt register mask. An alternatice approach would be to create
> 	a new chip type for PCA953X_TYPE chips with the mask register.
> 	What do you think?

Consider avoiding the change of the ID tables in almost every patch you have.
This can be achiever by carefully allocating bits for types and define the
actual HW via bit ORed masks.

-- 
With Best Regards,
Andy Shevchenko