Re: [PATCH v5 2/3] gpio: pca9570: add a platform data structure

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Oct 26, 2022 at 12:00:34PM +0200, Geert Uytterhoeven wrote:
> Hi Shubhrajyoti,
> On Fri, Sep 30, 2022 at 12:41 PM Shubhrajyoti Datta
> <shubhrajyoti.datta@xxxxxxx> wrote:

...

> Thanks for your patch, which is now commit 35a4bc94a47f2ea6 ("gpio:
> pca9570: add a platform data structure") in gpio/gpio/for-next
> linux-next/master next-20221026

Dunno if Bart rebases his tree...

...

> >  static const struct of_device_id pca9570_of_match_table[] = {
> > -       { .compatible = "nxp,pca9570", .data = (void *)4 },
> > -       { .compatible = "nxp,pca9571", .data = (void *)8 },
> > +       { .compatible = "nxp,pca9570", .data = &pca9570_gpio },
> > +       { .compatible = "nxp,pca9571", .data = &pca9571_gpio },
> 
> This breaks bisection, as .data is still considered to be the number
> of GPIOs:
> 
>     gpio->chip.ngpio = (uintptr_t)device_get_match_data(&client->dev);

You beat me up to it, I have also noticed this.

> >         { /* sentinel */ }
> >  };

-- 
With Best Regards,
Andy Shevchenko