Hi Linus, > Fine by me: > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Out of curiosity: what device/SoC are you using this driver with? Thanks for the review. We're using the ftgpio driver for GPIO peripherals on the microwatt CPU implementation; the driver uses a simple & sensible register layout, so we've based the gateware on that: https://github.com/CodeConstruct/microwatt/commit/03293903 That's a fairly arbitrary choice, but it works well as-is. Cheers, Jeremy