[PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> sdm670_reserved_gpios is only used in pinctrl-sdm670.c now, change it
> to static.
> 
> Fixes: 61164d220f52 ("pinctrl: qcom: add sdm670 pinctrl")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

The email headers could maybe use a little work.

	From: Yang Yingliang <yangyingliang@xxxxxxxxxx>
	To: <linux-gpio@xxxxxxxxxxxxxxx>
	CC: <mailingradian@xxxxxxxxx>, <linus.walleij@xxxxxxxxxx>,
		<yangyingliang@xxxxxxxxxx>
	Subject: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static

You don't need to remove people's names from their email addresses; they can go
together like so (not a strict requirement, but a nice touch in everyone's
mailboxes):

	CC: Richard Acayan <mailingradian@xxxxxxxxx>,
		Linus Walleij <linus.walleij@xxxxxxxxxx>,
		Yang Yingliang <yangyingliang@xxxxxxxxxx>

For this patch, there is a typo in the subject:

-Subject: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static
+Subject: [PATCH -next] pinctrl: qcom: sdm670: change sdm670_reserved_gpios to static

Otherwise, it looks good.

Acked-by: Richard Acayan <mailingradian@xxxxxxxxx>

> ---
>  drivers/pinctrl/qcom/pinctrl-sdm670.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm670.c b/drivers/pinctrl/qcom/pinctrl-sdm670.c
> index 4c3c3782fef8..b888bca7ecd7 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sdm670.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sdm670.c
> @@ -1294,7 +1294,7 @@ static const struct msm_pingroup sdm670_groups[] = {
>  	SDC_QDSD_PINGROUP(sdc2_data, 0x9a000, 9, 0),
>  };
>  
> -const int sdm670_reserved_gpios[] = {
> +static const int sdm670_reserved_gpios[] = {
>  	58, 59, 60, 61, 62, 63, 64, 69, 70, 71, 72, 73, 74, 104, -1
>  };
>  
> -- 
> 2.25.1



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux