Re: [PATCH V7 1/8] libgpiod: Add libgpiod-sys rust crate

[Viresh Kumar <viresh.kumar@xxxxxxxxxx>]

On 17-10-22, 20:59, Kent Gibson wrote:
> > diff --git a/bindings/rust/libgpiod-sys/Cargo.toml b/bindings/rust/libgpiod-sys/Cargo.toml
> > new file mode 100644
> > index 000000000000..77f82719d269
> > --- /dev/null
> > +++ b/bindings/rust/libgpiod-sys/Cargo.toml
> > @@ -0,0 +1,15 @@
> > +[package]
> > +name = "libgpiod-sys"
> > +version = "0.1.0"
> > +edition = "2018"
> > +
> 
> Add license and other relevant keys as per the link you helpfully include...

Is this enough ?

diff --git a/bindings/rust/libgpiod-sys/Cargo.toml b/bindings/rust/libgpiod-sys/Cargo.toml
index 77f82719d269..af4098cb137d 100644
--- a/bindings/rust/libgpiod-sys/Cargo.toml
+++ b/bindings/rust/libgpiod-sys/Cargo.toml
@@ -1,6 +1,11 @@
 [package]
 name = "libgpiod-sys"
 version = "0.1.0"
+authors = ["Viresh Kumar <viresh.kumar@xxxxxxxxxx>"]
+description = "A rust library for libgpiod public header bindings"
+repository = "https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/";
+keywords = ["libgpiod", "gpio"]
+license = "LGPL-2.1-or-later"
 edition = "2018"

I picked license details from C code, is that what we should be using
here too ?

> > diff --git a/bindings/rust/libgpiod-sys/src/lib.rs b/bindings/rust/libgpiod-sys/src/lib.rs
> > new file mode 100644
> > index 000000000000..1ca355b5f5ac
> > --- /dev/null
> > +++ b/bindings/rust/libgpiod-sys/src/lib.rs
> > @@ -0,0 +1,13 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> 
> GPL-2.0?
> 
> Elsewhere you use Apache 2.0 AND BSD-3-Clause for rust code.

I would use the same information here too, once decided.

-- 
viresh