On 21/09/2022 11:50, Tomer Maimon wrote: > This patch set adds pinmux and GPIO controller for the Arbel NPCM8XX > Baseboard Management Controller (BMC). > > Arbel BMC NPCM8XX pinctrl driver based on Poleg NPCM7XX, except the > pin mux mapping difference the NPCM8XX GPIO supports adjust debounce > period time. > > Arbel BMC NPCM8XX Pinmux functions accessible only for pin groups > and pin configuration parameters available only for individual pins. > > Arbel BMC NPCM8XX has eight identical GPIO modules, > each module has 32 GPIO ports. > > Most of the GPIO ports are multiplexed with other system functions. > > The NPCM8XX pinctrl and GPIO driver were tested on NPCM845 evaluation board. > > Addressed comments from: > - Andy Shevchenko: https://lkml.org/lkml/2022/7/14/1218 > - Rob Herring: https://lkml.org/lkml/2022/7/18/1165 > - Krzysztof Kozlowski: https://lkml.org/lkml/2022/9/19/68 How did you address this comment? > Best regards, Krzysztof