Re: [libgpiod v2][PATCH] treewide: add support for hardware timestamp engine

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Fri, Sep 23, 2022 at 10:12:23AM +0200, Bartosz Golaszewski wrote:
> Since v5.19 the linux GPIO uAPI exposes a new request flag for making
> the hardware timestamp engine be the source of edge event timestamps.
> Add support for it to libgpiod.

...

>  	/**
>  	 * @brief Read the current event clock setting used for edge event
>  	 *        timestamps.
> -	 * @return Returns MONOTONIC or REALTIME.
> +	 * @return Returns MONOTONIC, REALTIME or HTE.

Is it possible to refer to these with % so doxygen (or whatever you are using)
make the links out of them?

Because HTE is way too cryptic TLA (the same concern was also during submission
of that framework into the Linux kernel).

>  	 */

...

>  	{ line::clock::MONOTONIC,	"MONOTONIC" },
> -	{ line::clock::REALTIME,	"REALTIME" }
> +	{ line::clock::REALTIME,	"REALTIME" },
> +	{ line::clock::HTE,		"HTE" }

Similar here and hey, have you got the idea of the trailing comma (or poor C++
forbids that?)?

-- 
With Best Regards,
Andy Shevchenko