> -----Original Message----- > From: Bartosz Golaszewski <brgl@xxxxxxxx> > Sent: 2022年9月22日 16:23 > To: Bough Chen <haibo.chen@xxxxxxx> > Cc: linus.walleij@xxxxxxxxxx; dmitry.torokhov@xxxxxxxxx; > linux-gpio@xxxxxxxxxxxxxxx; Aisheng Dong <aisheng.dong@xxxxxxx>; > dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH] gpiolib: add NULL to the end of arry of_find_gpio_quirks[] > > On Wed, Sep 21, 2022 at 10:02 AM <haibo.chen@xxxxxxx> wrote: > > > > From: Haibo Chen <haibo.chen@xxxxxxx> > > > > After commit a2b5e207cade ("gpiolib: rework quirk handling in > > of_find_gpio()"), it add an arry of_find_gpio_quirks[], but in the for > > loop, it use *q to judge whether it is out of the arry range. > > Unfortunately, in the arry, forget to add NULL in the end, which has > > the risk of out of arry access, here is the dump on i.MX8MM-evk board: > > > > This was already fixed by Michael Walle. I just find the fix patch already in next-20220921. Thanks for the reminder. Best Regards Haibo Chen > > Bart