Re: [PATCH 1/2 v2] pinctrl: nomadik: Dereference gpio_chip properly

[Marc Zyngier <maz@xxxxxxxxxx>]

On Sat, 17 Sep 2022 21:30:35 +0100,
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> 
> The irq data passed to irc_chip handlers i the struct gpio_chip

s/i/is/ ?

> and nothing else. We are just lucky that the nomadik chip
> pointer is first in the struct. Use the proper dereferencing
> and helpers.
> 
> Reported-by: Marc Zyngier <maz@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> ChangeLog v1->v2:
> - New patch for a bug identified by Marc.
> ---
>  drivers/pinctrl/nomadik/pinctrl-nomadik.c | 30 +++++++++--------------
>  1 file changed, 12 insertions(+), 18 deletions(-)

Acked-by: Marc Zyngier <maz@xxxxxxxxxx>

	M.

-- 
Without deviation from the norm, progress is not possible.