On Thu, Sep 8, 2022 at 4:03 PM Catalin Petrescu <catalin.petrescu@xxxxxxxxx> wrote: > > Hi there, > > I found a small error (IMHO) in libgpiod. > The issue is that asprintf may return -1 if it fails to allocate > memory, and if that happens, chip_open_by_number will pass a NULL > pointer to gpiod_chip_open. > > I hope this helps. > > Thanks, > > Catalin. Hey Catalin, Please next time send the patch inline using git's send-email command. You're right about the error code check but it should actually be ret < 0 as per asprintf's documentation. Bart
Re: [PATCH] tools: Change asprintf return code check
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] tools: Change asprintf return code check
- From: Bartosz Golaszewski <brgl@xxxxxxxx>
- Date: Tue, 13 Sep 2022 16:47:17 +0200
- In-reply-to: <e8bf314dd0edfd0709d71e85fb8d877c3722e33e.camel@gmail.com>
- References: <e8bf314dd0edfd0709d71e85fb8d877c3722e33e.camel@gmail.com>
- Follow-Ups:
- Re: [PATCH] tools: Change asprintf return code check
- From: Catalin Petrescu
- Re: [PATCH] tools: Change asprintf return code check
- References:
- [PATCH] tools: Change asprintf return code check
- From: Catalin Petrescu
- [PATCH] tools: Change asprintf return code check
- Prev by Date: Re: [PATCH 1/2] gpio: mt7621: Switch to use fwnode instead of of_node
- Next by Date: Re: [PATCH 2/2] gpiolib: cdev: export the consumer's PID
- Previous by thread: [PATCH] tools: Change asprintf return code check
- Next by thread: Re: [PATCH] tools: Change asprintf return code check
- Index(es):
 |