Re: [PATCH v3 2/5] dt-bindings: gpio: pca95xx: add entry for pcal6534 and PI4IOE5V6534Q

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2022-09-12 at 10:38 -0500, Rob Herring wrote:
> On Mon, 12 Sep 2022 11:22:19 +0100, Martyn Welch wrote:
> > From: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>
> > 
> > The NXP PCAL6534 is a 34-bit I2C I/O expander similar to the
> > PCAL6524. The
> > Diodes PI4IOE5V6534Q is a functionally identical chip provided by
> > Diodes
> > Inc.
> > 
> > Signed-off-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > ---
> > 
> > Changes in v2:
> >  - Enumerate pi4ioe5v6534q as requiring pcal6534 fallback
> > 
> > Changes in v3:
> >  - Corrected indentation
> > 
> >  .../bindings/gpio/gpio-pca95xx.yaml           | 98 ++++++++++-----
> > ----
> >  1 file changed, 52 insertions(+), 46 deletions(-)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml:24:13:
> [warning] wrong indentation: expected 14 but found 12 (indentation)
> 

Not sure why this didn't show up running the above command, but after
updating dtschema, it seems to be showing up now. Working on v4...

Martyn

> dtschema/dtc warnings/errors:
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/
> 
> This check can fail if there are any dependencies. The base for a
> patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up
> to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
> 




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux