Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> Move the default values to the 'default' case in the switches.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Patch applied!

>         case CY8C95X0_DRV_PP_SLOW:
>         case CY8C95X0_DRV_HIZ:
>                 return true;
> +       default:
> +               return false;
>         }
> -
> -       return false;
>  }

Clearly this is better style, I wonder if we could teach checkpatch to
look for this? Or cocinelle?

Yours,
Linus Walleij



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux