On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > Move the default values to the 'default' case in the switches. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Patch applied! > case CY8C95X0_DRV_PP_SLOW: > case CY8C95X0_DRV_HIZ: > return true; > + default: > + return false; > } > - > - return false; > } Clearly this is better style, I wonder if we could teach checkpatch to look for this? Or cocinelle? Yours, Linus Walleij