RE: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[<Kumaravel.Thiagarajan@xxxxxxxxxxxxx>]

> -----Original Message-----
> From: Arnd Bergmann <arnd@xxxxxxxx>
> Sent: Wednesday, September 7, 2022 2:12 PM
> To: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>; Greg Kroah-
> Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@xxxxxxxxxxxxx>; open list:GPIO SUBSYSTEM
> <linux-gpio@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>;
> linux-next <linux-next@xxxxxxxxxxxxxxx>
> Subject: Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc:
> microchip: pci1xxxx: Add power management functions - suspend & resume
> handlers.")
> 
> 
> On Tue, Sep 6, 2022, at 11:07 PM, Sudip Mukherjee wrote:
> > On Tue, Sep 6, 2022 at 6:15 PM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >> On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink)
> wrote:
> >> >
> >> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error:
> 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
> >> >   311 | static int pci1xxxx_gpio_resume(struct device *dev)
> >> >       |            ^~~~~~~~~~~~~~~~~~~~
> >> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error:
> 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
> >> >   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> >> >       |            ^~~~~~~~~~~~~~~~~~~~~
> >> >
> >> >
> >> > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add
> power management functions - suspend & resume handlers.").
> >> >
> >
> > Looking at other drivers which uses SIMPLE_DEV_PM_OPS, I think
> > pci1xxxx_gpio_suspend() and pci1xxxx_gpio_resume() needs to be under
> > "#ifdef CONFIG_PM_SLEEP".
Thank you Sudip ! I will review this.
> 
> That would work, but a better fix is to use DEFINE_SIMPLE_DEV_PM_OPS()
> in place of the deprecated SIMPLE_DEV_PM_OPS().
Thank you Arnd ! I will review this.