RE: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile

[Jacky Bai <ping.bai@xxxxxxx>]

> Subject: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
> 
> PINCTRL_IMX depends on OF, however the dependency is missed when
> selected by PINCTRL_IMX8M* (it does not follow the indirect 'select'
> statements), select it explicitly.
> 
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
...
> Fixes: 87c2a29a6bf1 ("pinctrl: imx8m: kconfig: Depends on SOC_IMX8M")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>

Reviewed-by: Jacky Bai <ping.bai@xxxxxxx>

BR

> ---
> Linus: I did test on s390 and it's fine, but the topic is tricky for me ...
> ---
>  drivers/pinctrl/freescale/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index 365fcff8e470..7a32f77792d9 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -119,6 +119,7 @@ config PINCTRL_IMX7ULP
> 
>  config PINCTRL_IMX8MM
>  	tristate "IMX8MM pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> @@ -126,6 +127,7 @@ config PINCTRL_IMX8MM
> 
>  config PINCTRL_IMX8MN
>  	tristate "IMX8MN pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> @@ -133,6 +135,7 @@ config PINCTRL_IMX8MN
> 
>  config PINCTRL_IMX8MP
>  	tristate "IMX8MP pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> @@ -140,6 +143,7 @@ config PINCTRL_IMX8MP
> 
>  config PINCTRL_IMX8MQ
>  	tristate "IMX8MQ pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> --
> 2.25.1