Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs

[Hector Martin <marcan@xxxxxxxxx>]

On 02/09/2022 19.05, Russell King (Oracle) wrote:
> but even that isn't _that_ nice. I'd like to hear comments from the Asahi
> folk about whether these sub-blocks of the SMC can have compatibles, so
> that the MFD layer can automatically fill in the firmware nodes on the
> struct device before the probe function gets called.

I'm fine with adding compatibles if this makes the of/fwnode handling
simpler. However, keep in mind these aren't hardware, they're
effectively software services implemented in a coprocessor. The idea
behind not having compatibles was that the SMC stuff should be
self-discovering enough that it can decide what's available and not at
runtime, and that the SMC core needs to probe before the child devices
anyway, so it's not like this can be a simple-bus. But I'm new to the
MFD subsystem, so if compatibles make life easier, sure.

Personally, I'd defer to Rob's opinon on this (CC'ed), since he has the
last word on DT bindings :).

- Hector