Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs

[Martin Povišer <povik@xxxxxxxxxxx>]

> On 1. 9. 2022, at 20:55, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> 
> On Thu, Sep 1, 2022 at 5:17 PM Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote:

>> + ret = apple_smc_write_u32(smcgp->smc, key, CMD_OUTPUT | value);
>> + if (ret < 0)
>> + dev_err(smcgp->dev, "GPIO set failed %p4ch = 0x%x\n", &key, value);
> 
> Strange specifier... It seems like a hashed pointer with added (or
> skipped? I don't remember) '4ch'. Perhaps you meant one of '%pE',
> '%p4cc'?
> Ditto for other cases.

As was pointed out by Sven elsewhere in the thread, this is an
unupstreamed specifier (that was missed as a dependency of this
code).

https://github.com/AsahiLinux/linux/blob/f8c0d18173a7b649999ee27515393f7aae40310c/Documentation/core-api/printk-formats.rst#generic-fourcc-code

Martin