Re: [PATCH v2 1/2] gpio: Add gpio latch driver

[Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>]

On Wed, Aug 31, 2022 at 10:01:09AM +0200, Marco Felsch wrote:
> Hi Sascha,
> 
> On 22-08-31, Sascha Hauer wrote:
> > This driver implements a GPIO multiplexer based on latches connected to
> > other GPIOs. A set of data GPIOs is connected to the data input of
> > multiple latches. The clock input of each latch is driven by another
> > set of GPIOs. With two 8-bit latches 10 GPIOs can be multiplexed into
> > 16 GPIOs. GPOs might be a better term as in fact the multiplexed pins
> > are output only.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> 
> apart the one minor nit (see end) feel free to add my
> 
> Reviewed-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> 
> > +// SPDX-License-Identifier: GPL-2.0-or-later

[snip]

> > +MODULE_LICENSE("GPL v2");
> 
> checkpatch.pl should complain about this since it it now GPL, see commit
> bf7fbeeae6db. Sorry for not spotted that earlier.

Just checked, checkpatch doesn't complain. Will fix in v3

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |