On 2022-08-30 09:12, Manivannan Sadhasivam wrote:
The IRQCHIP implementation used inside the gpiochips are not supposed
to
lower case
be changed during runtime. So let's make the one inside the spmi-gpio
gpiochip immutable.
This fixes the below warning during boot:
gpio gpiochip0: (c440000.spmi:pmic@0:gpio@c000): not an immutable
chip, please consider fixing it!
Separate callbacks need to be provided for irq_{mask/unmask} pointers
since
the callbacks are supposed to mask/unmask the corresponding parent IRQ
in
addition to changing the gpio_desc flags.
This is all part of the existing documentation, so I don't think
this is really needed.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
With the above fixed:
Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
M.
--
Jazz is not dead. It just smells funny...
