RE: [PATCH v3 01/10] input: keyboard: adp5588-keys: support gpi key events as 'gpio keys'

["Sa, Nuno" <Nuno.Sa@xxxxxxxxxx>]

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Monday, July 25, 2022 10:32 PM
> To: kernel test robot <lkp@xxxxxxxxx>
> Cc: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; linux-input <linux-
> input@xxxxxxxxxxxxxxx>; open list:GPIO SUBSYSTEM <linux-
> gpio@xxxxxxxxxxxxxxx>; devicetree <devicetree@xxxxxxxxxxxxxxx>;
> llvm@xxxxxxxxxxxxxxx; kbuild-all@xxxxxxxxxxxx; Linus Walleij
> <linus.walleij@xxxxxxxxxx>; Krzysztof Kozlowski <krzk@xxxxxxxxxx>;
> Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Bartosz
> Golaszewski <brgl@xxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
> Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Subject: Re: [PATCH v3 01/10] input: keyboard: adp5588-keys: support
> gpi key events as 'gpio keys'
> 
> [External]
> 
> On Sat, Jul 23, 2022 at 6:57 AM kernel test robot <lkp@xxxxxxxxx>
> wrote:
> 
> 
> ...
> 
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/input/keyboard/adp5588-keys.c:336:9: warning: implicit
> conversion from 'unsigned long' to 'int' changes value from
> 18446744073709551615 to -1 [-Wconstant-conversion]
> >            return INVALID_HWIRQ;
> >            ~~~~~~ ^~~~~~~~~~~~~
> >    include/linux/irq.h:1245:24: note: expanded from macro
> 'INVALID_HWIRQ'
> >    #define INVALID_HWIRQ   (~0UL)
> >                             ^~~~
> 
> It requires irq.h, but hold on. Marc said that he wants to rather kill
> that definition than having it spread over the kernel. So, please use
> your own custom macro with an appropriate type.
> 

I see, I'll probably just replicate the macro with an "ADP5588" prefix...

Thx,
- Nuno Sá