On Fri, Aug 19, 2022 at 9:01 PM Apurva Nandan <a-nandan@xxxxxx> wrote: > Add pinctrl macros for J784s4 SoC. These macro definitions are > similar to that of J721s2, but adding new definitions to avoid > any naming confusions in the soc dts files. > > checkpatch insists the following error exists: > ERROR: Macros with complex values should be enclosed in parentheses > > However, we do not need parentheses enclosing the values for this > macro as we do intend it to generate two separate values as has been > done for other similar platforms. > > Signed-off-by: Hari Nagalla <hnagalla@xxxxxx> > Signed-off-by: Apurva Nandan <a-nandan@xxxxxx> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> I guess you will merge these patches together? Tell me if you rather want that I apply this one patch to the pinctrl tree. Yours, Linus Walleij