Re: [PATCH 1/1] Pinctrl: Add in zero check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 25, 2022 at 3:07 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Aug 16, 2022 at 11:09 AM Will Shiu <Will.Shiu@xxxxxxxxxxxx> wrote:
>
> > add in check of buffer offset to avoid the exception when input 0 size.
> >
> > Signed-off-by: Will Shiu <Will.Shiu@xxxxxxxxxxxx>
>
> Looks good to me, patch applied!

Sorry, but it seems the author didn't pay much attention and didn't
really work on it. What does the < 0 comparison mean here?

I would ask if there is _real_ issue with the code? What is the use
case and why is this check needed?

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux