Re: [PATCH v5 0/2] gpio: mxc: Locking and direction input fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/25/22 17:50, Marc Zyngier wrote:
On Mon, 25 Jul 2022 11:34:43 +0100,
Marek Vasut <marex@xxxxxxx> wrote:

The irqchip callbacks in gpio-mxc perform register read-modify-write operations
without locking, which may lead to a race condition. Add the missing locking.

In case the GPIO is used as IRQ, make sure it is configured as input.

Marek Vasut (2):
   gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock
   gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode

  drivers/gpio/gpio-mxc.c | 17 ++++++++++++++++-
  1 file changed, 16 insertions(+), 1 deletion(-)

Cc: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
Cc: Loic Poulain <loic.poulain@xxxxxxxxxx>
Cc: Marc Zyngier <maz@xxxxxxxxxx>
Cc: NXP Linux Team <linux-imx@xxxxxxx>
Cc: Peng Fan <peng.fan@xxxxxxx>
Cc: Shawn Guo <shawnguo@xxxxxxxxxx>

Reviewed-by: Marc Zyngier <maz@xxxxxxxxxx>

Can these two now be applied or is there something more to do ?



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux