Re: [PATCH] pinctrl: rockchip: Enhance support for IRQ_TYPE_EDGE_BOTH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag, 22. August 2022, 11:03:08 CEST schrieb Linus Walleij:
> On Mon, Aug 8, 2022 at 4:53 AM João H. Spies <jhlspies@xxxxxxxxx> wrote:
> 
> > Switching between falling/rising edges for IRQ_TYPE_EDGE_BOTH on pins that
> > require debounce can cause the device to lose events due to a desync
> > between pin state and irq type.
> >
> > This problem is resolved by switching between IRQ_TYPE_LEVEL_LOW and
> > IRQ_TYPE_LEVEL_HIGH instead.
> >
> > Fixes: 936ee26 ("gpio/rockchip: add driver for rockchip gpio")
> > Signed-off-by: João H. Spies <jhlspies@xxxxxxxxx>
> 
> No reaction from maintainers so I'm just gonna assume this fix is
> correct and applied for fixes.

This plays with behavioral peculiarities of the gpio controller
(using the level setting to hopefully prevent missing edge irqs),
so doesn't follow

So I guess it really is more of a wait-and-see. And I guess as João
seems to have experienced that issue, that will hopefully work
for others too.

Heiko





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux