RE: [EXT] Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver

[Shenwei Wang <shenwei.wang@xxxxxxx>]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Friday, August 5, 2022 1:57 AM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; linus.walleij@xxxxxxxxxx; brgl@xxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> gpio@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v1 3/3] firmware: imx: add imx-scu GPIO driver
> 
> Caution: EXT Email
> 
> On 04/08/2022 20:49, Shenwei Wang wrote:
> > The SCU firmware on i.MX8 platforms provides a set of APIs to control
> > the GPIO PINs on the SCU domain. This patch implements the standard
> > GPIO driver interface to access those PINs on the SCU domain over the
> > SCU APIs.
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang@xxxxxxx>
> > ---
> >  drivers/firmware/imx/Kconfig        |   6 ++
> >  drivers/firmware/imx/Makefile       |   1 +
> >  drivers/firmware/imx/imx-scu-gpio.c | 139
> > ++++++++++++++++++++++++++++
> >  3 files changed, 146 insertions(+)
> >  create mode 100644 drivers/firmware/imx/imx-scu-gpio.c
> >
> > diff --git a/drivers/firmware/imx/Kconfig
> > b/drivers/firmware/imx/Kconfig index c027d99f2a59..484c13f3149a 100644
> > --- a/drivers/firmware/imx/Kconfig
> > +++ b/drivers/firmware/imx/Kconfig
> > @@ -28,3 +28,9 @@ config IMX_SCU_PD
> >       depends on IMX_SCU
> >       help
> >         The System Controller Firmware (SCFW) based power domain driver.
> > +
> > +config IMX_SCU_GPIO
> > +       def_bool y
> > +       depends on IMX_SCU
> > +       help
> > +         Say Y here to enable the imx8 gpio over SCFW MISC API
> 
> gpio driver go to drivers/gpio/

I was thinking to put the driver under drivers/gpio at the beginning too. Are there any requirements to put a driver under firmware directory?

Thanks,
Shenwei

> 
> Best regards,
> Krzysztof