On 01-08-22, 20:38, Kent Gibson wrote: > The request_lines() could be considered sufficient to test > the conversions for both request_config and line_config objects. > > But testing request_lines() and reconfigure_lines() doesn't just test > those conversions, it checks that the functions don't mess with the > config along the way. > If you want to take that as a given then sure, just testing the > config variants for request_lines() will do. Okay, so we want test setting various flag types in line_config and then see if request_line() fails or not and verify (read) them later. Right ? Very similar to this is also done in tests/line_info now, where you suggested: "Test that you can read all supported values for all fields." So I set all possible values for fields and then read them back. Lets see after the next version, if they are sufficient or not. I will happily add more if required then. Thanks. -- viresh