Re: [PATCH V4 5/8] libgpiod: Add rust examples

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 27, 2022 at 03:36:33PM +0530, Viresh Kumar wrote:
> On 27-07-22, 17:59, Kent Gibson wrote:
> > For long enough for the user to check that the line is set, as there is
> > the possibility that when the line is released it will be set back to
> > its default value and you will get users reporting that your set
> > doesn't work ;-).
> > 
> > So wait for a keypress?
> 
> I thought we wanted to avoid human-intervention to the tests :)
> 

This is for an example gpioset, right?
You have tests for your examples?

And even then you could either inject a keypress or just kill the
process. (e.g. the tests for the proposed tool changes do that)

Cheers,
Kent.

> Can't we just read the values of the lines again here somehow and match ? I
> don't expect/want the user to do this for running the test. Not to mention, the
> user may eventually be a bot running the tests for each commit added to the
> tree.
> 





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux