Re: [PATCH] pinctrl:Missing a blank line after declarations.

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Xin!

Top-posting because you missed to include the mailing list.

The patch is fine though, so applied!

Yours,
Linus Walleij

On Tue, Jul 19, 2022 at 8:27 PM Xin Gao <gaoxin@xxxxxxxxxx> wrote:

> Missing a blank line after declarations.
>
> Signed-off-by: Xin Gao <gaoxin@xxxxxxxxxx>
> ---
>  drivers/pinctrl/mvebu/pinctrl-mvebu.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> index a1f93859e7ca..8ef0a97d2bf5 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> @@ -96,10 +96,12 @@ static struct mvebu_pinctrl_group *mvebu_pinctrl_find_group_by_name(
>         struct mvebu_pinctrl *pctl, const char *name)
>  {
>         unsigned n;
> +
>         for (n = 0; n < pctl->num_groups; n++) {
>                 if (strcmp(name, pctl->groups[n].name) == 0)
>                         return &pctl->groups[n];
>         }
> +
>         return NULL;
>  }
>
> @@ -108,6 +110,7 @@ static struct mvebu_mpp_ctrl_setting *mvebu_pinctrl_find_setting_by_val(
>         unsigned long config)
>  {
>         unsigned n;
> +
>         for (n = 0; n < grp->num_settings; n++) {
>                 if (config == grp->settings[n].val) {
>                         if (!pctl->variant || (pctl->variant &
> @@ -115,6 +118,7 @@ static struct mvebu_mpp_ctrl_setting *mvebu_pinctrl_find_setting_by_val(
>                                 return &grp->settings[n];
>                 }
>         }
> +
>         return NULL;
>  }
>
> @@ -123,6 +127,7 @@ static struct mvebu_mpp_ctrl_setting *mvebu_pinctrl_find_setting_by_name(
>         const char *name)
>  {
>         unsigned n;
> +
>         for (n = 0; n < grp->num_settings; n++) {
>                 if (strcmp(name, grp->settings[n].name) == 0) {
>                         if (!pctl->variant || (pctl->variant &
> @@ -130,6 +135,7 @@ static struct mvebu_mpp_ctrl_setting *mvebu_pinctrl_find_setting_by_name(
>                                 return &grp->settings[n];
>                 }
>         }
> +
>         return NULL;
>  }
>
> @@ -137,6 +143,7 @@ static struct mvebu_mpp_ctrl_setting *mvebu_pinctrl_find_gpio_setting(
>         struct mvebu_pinctrl *pctl, struct mvebu_pinctrl_group *grp)
>  {
>         unsigned n;
> +
>         for (n = 0; n < grp->num_settings; n++) {
>                 if (grp->settings[n].flags &
>                         (MVEBU_SETTING_GPO | MVEBU_SETTING_GPI)) {
> @@ -145,6 +152,7 @@ static struct mvebu_mpp_ctrl_setting *mvebu_pinctrl_find_gpio_setting(
>                                 return &grp->settings[n];
>                 }
>         }
> +
>         return NULL;
>  }
>
> @@ -152,10 +160,12 @@ static struct mvebu_pinctrl_function *mvebu_pinctrl_find_function_by_name(
>         struct mvebu_pinctrl *pctl, const char *name)
>  {
>         unsigned n;
> +
>         for (n = 0; n < pctl->num_functions; n++) {
>                 if (strcmp(name, pctl->functions[n].name) == 0)
>                         return &pctl->functions[n];
>         }
> +
>         return NULL;
>  }
>
> --
> 2.30.2
>