Re: [PATCH v3 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 25 Jul 2022 10:57:32 +0100,
Marek Vasut <marex@xxxxxxx> wrote:
> 
> On 7/25/22 08:53, Marc Zyngier wrote:
> > However, you have totally ignored my earlier comments in your v4:
> > 
> > - This doesn't compile, as bgpio_lock has been changed to a *raw*
> >    spinlock. You obviously haven't even bothered testing your patch.
> 
> Yes indeed, I tested every single one on 5.18.y . I noticed the raw
> spinlock change is only in next.

$ git describe --contains 3c938cc5cebcb --match=v*
v5.19-rc1~134^2~25

Only in -next? Not quite.

> 
> > - I asked for a cover letter for any series with multiple patch.
> >    That's not exactly a new requirement.
> > 
> > So we got 4 versions in just over 24 hours, none of which actually
> > work. Do you see the overarching problem?
> 
> Lemme rebase this on next and send v5.

Rebasing on -rc1 is the right thing to do. You should never base
something on -next, as this is a moving target.

	M.

-- 
Without deviation from the norm, progress is not possible.



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux