Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli
<srinivas.neeli@xxxxxxxxxx> wrote:
>
> Current implementation is not able to configure more than 32 pins
> due to incorrect data type. So type casting with unsigned long
> to avoid it.
>
> Fixes: 02b3f84d9080 ("xilinx: Switch to use bitmap APIs")
> Signed-off-by: Srinivas Neeli <srinivas.neeli@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-xilinx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index b6d3a57e27ed..7f8e2fed2988 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -99,7 +99,7 @@ static inline void xgpio_set_value32(unsigned long *map, int bit, u32 v)
>         const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5);
>
>         map[index] &= ~(0xFFFFFFFFul << offset);
> -       map[index] |= v << offset;
> +       map[index] |= (unsigned long)v << offset;
>  }
>
>  static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)
> --
> 2.17.1
>

Applied, thanks!

Bart